In addition to the standard CX-40 and PainLine controllers, I have...
This weird one, which I acquired recently in an eBay auction. The raised text around the stick says NEWPORT CONTROLLERS on the top and BISHOP, CA PATENT PENDING on the bottom. It's a plain-yet-weird looking controller, but it works amazingly well:
Also from the same auction is this thing I've never seen: the BC Blaster from B.C. Systems in Melrose, Massachusetts. The stuff I got in the auction was packed very poorly and the fire button broke off, but this morning I glued it back on with Gorilla Glue (and obviously I didn't glue it perfectly evenly!) and it's holding on VERY well. (Those of you who listen to either of my podcasts -- this is what I was talking about.) It's a very light controller -- the bulky fake wood box is virtually empty. Played it on both 2600 Asteroids and 7800 Asteroids DeLuxe to great success!
And this is my UberArcade joystick made specifically for the 7800, but of course it works in anything that takes a 9-pin joystick. It's a fantastic 8-way joystick, but it's very frustrating on 4-way games -- very sensitive:
Aaaaaaand, of course, the one I seemingly never shut up about: the Edladdin All-Play 4/8 Supreme 78. Lift up the panel and there's a ring you turn to alternate between 8-way and 4-way: